implement review

- Remove trailing tooltip "."
- Add `AddSettingsButton` method
- Simplify loop into LINQ expression

Source/Editor/CustomEditors/Dedicated/ActorEditor.cs

@@ -115,7 +115,7 @@ namespace FlaxEditor.CustomEditors.Dedicated
                 {
                     if (actor != null)
                         group.Panel.TooltipText = Surface.SurfaceUtils.GetVisualScriptTypeDescription(TypeUtils.GetObjectType(actor));
-                    var settingsButton = group.AddHeaderButton("Settings.", 0.0f, FlaxEngine.GUI.Style.Current.Settings);
+                    var settingsButton = group.AddSettingsButton();
                     settingsButton.Clicked += OnSettingsButtonClicked;
                     break;
                 }

Source/Editor/CustomEditors/Dedicated/ScriptsEditor.cs

@@ -640,7 +640,7 @@ namespace FlaxEditor.CustomEditors.Dedicated
             var group = layout.Group("Missing script");
 
             // Add settings button to the group
-            var settingsButton = group.AddHeaderButton("Settings.", 0.0f, FlaxEngine.GUI.Style.Current.Settings);
+            var settingsButton = group.AddSettingsButton();
             settingsButton.Tag = index;
             settingsButton.Clicked += MissingSettingsButtonOnClicked;
         }
@@ -907,21 +907,14 @@ namespace FlaxEditor.CustomEditors.Dedicated
                 };
 
                 // Add settings button to the group
-                var settingsButton = group.AddHeaderButton("Settings.", 0.0f, _style.Settings);
+                var settingsButton = group.AddSettingsButton();
                 settingsButton.Tag = script;
                 settingsButton.Clicked += OnSettingsButtonClicked;
 
                 // Add script obsolete icon to the group
                 if (scriptType.HasAttribute(typeof(ObsoleteAttribute), false))
                 {
-                    ObsoleteAttribute attribute = null;
-                    foreach (var e in scriptType.GetAttributes(false))
-                    {
-                        if (e is not ObsoleteAttribute obsoleteAttribute)
-                            continue;
-                        attribute = obsoleteAttribute;
-                        break;
-                    }
+                    ObsoleteAttribute attribute = (ObsoleteAttribute)scriptType.GetAttributes(false).First(x => x is ObsoleteAttribute);
 
                     string tooltip = "Script marked as obsolete." +
                         (string.IsNullOrEmpty(attribute.Message) ? "" : $"\n{attribute.Message}") +

Source/Editor/CustomEditors/Elements/Container/GroupElement.cs

@@ -37,7 +37,16 @@ namespace FlaxEditor.CustomEditors.Elements
         public override ContainerControl ContainerControl => Panel;
 
         /// <summary>
-        /// Adds utility settings button to the group header.
+        /// Add utility settings button to the group header.
+        /// </summary>
+        /// <returns>The created control.</returns>
+        public Image AddSettingsButton()
+        {
+            return AddHeaderButton("Settings", 0, Style.Current.Settings);
+        }
+
+        /// <summary>
+        /// Adds a button to the group header.
         /// </summary>
         /// <returns>The created control.</returns>
         public Image AddHeaderButton(string tooltipText, float xOffset, SpriteHandle sprite)

Source/Editor/Windows/Assets/MaterialInstanceWindow.cs

@@ -249,7 +249,7 @@ namespace FlaxEditor.Windows.Assets
                     return;
 
                 var parametersGroup = SurfaceUtils.InitGraphParametersGroup(layout);
-                var settingButton = parametersGroup.AddHeaderButton("Settings.", 0.0f, FlaxEngine.GUI.Style.Current.Settings);
+                var settingButton = parametersGroup.AddSettingsButton();
                 settingButton.Clicked += (image, button) => OnSettingsButtonClicked(image, button, proxy.Window);
                 var baseMaterial = materialInstance.BaseMaterial;
                 var material = baseMaterial;

Source/Editor/Windows/Assets/SkinnedModelWindow.cs

@@ -284,7 +284,7 @@ namespace FlaxEditor.Windows.Assets
                         var setupGroup = layout.Group(Path.GetFileNameWithoutExtension(sourceAsset.Path));
                         setupGroup.Panel.Tag = sourceAsset;
                         setupGroup.Panel.MouseButtonRightClicked += OnPanelHeaderRightClicked;
-                        var settingsButton = setupGroup.AddHeaderButton("Settings.", 0.0f, FlaxEngine.GUI.Style.Current.Settings);
+                        var settingsButton = setupGroup.AddSettingsButton();
                         settingsButton.Tag = sourceAsset;
                         settingsButton.Clicked += OnShowSetupSettings;