Flax/FlaxEngine
3
0
Fork 0
Code Issues Pull Requests Releases Activity

Fix crash on Vulkan when constant buffer is missing

Browse Source
This commit is contained in:
Wojciech Figat
2026-04-24 12:20:32 +02:00
parent d6113be58c
commit 881bc4d629
2 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Source/Engine/GraphicsDevice/Vulkan/GPUContextVulkan.cpp
+8 -1
View File
@@ -604,7 +604,14 @@ void GPUContextVulkan::UpdateDescriptorSets(const SpirvShaderDescriptorInfo& des
VkDeviceSize offset = 0, range = 0; VkDeviceSize offset = 0, range = 0;
uint32 dynamicOffset = 0; uint32 dynamicOffset = 0;
if (!handle) if (!handle)
handle = (GPUConstantBufferVulkan*)_device->HelperResources.GetDummyConstantBuffer(); {
auto cb = (GPUConstantBufferVulkan*)_device->HelperResources.GetDummyConstantBuffer();
// TODO: cache this allocation within a frame
const auto allocation = _device->UniformBufferUploader->Allocate(cb->GetSize(), 0, this);
Platform::MemoryClear(allocation.CPUAddress, allocation.Size);
cb->Allocation = allocation;
handle = cb;
}
handle->DescriptorAsDynamicUniformBuffer(this, buffer, offset, range, dynamicOffset); handle->DescriptorAsDynamicUniformBuffer(this, buffer, offset, range, dynamicOffset);
needsWrite |= dsWriter.WriteDynamicUniformBuffer(descriptorIndex, buffer, offset, range, dynamicOffset, index); needsWrite |= dsWriter.WriteDynamicUniformBuffer(descriptorIndex, buffer, offset, range, dynamicOffset, index);
break; break;
Source/Engine/GraphicsDevice/Vulkan/GPUDeviceVulkan.cpp
+1 -3
View File
@@ -946,9 +946,7 @@ GPUBufferVulkan* HelperResourcesVulkan::GetDummyVertexBuffer()
GPUConstantBuffer* HelperResourcesVulkan::GetDummyConstantBuffer() GPUConstantBuffer* HelperResourcesVulkan::GetDummyConstantBuffer()
{ {
if (!_dummyCB) if (!_dummyCB)
{ _dummyCB = _device->CreateConstantBuffer(1024, TEXT("DummyConstantBuffer"));
_dummyCB = _device->CreateConstantBuffer(256, TEXT("DummyConstantBuffer"));
}
return _dummyCB; return _dummyCB;
} }